Fix: Scheduler Actor Reminders Wording #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…othing to do with it really Signed-off-by: Cassandra Coyle <[email protected]>
msfussell
reviewed
Aug 15, 2024
daprdocs/content/en/operations/support/support-preview-features.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Cassie Coyle <[email protected]>
msfussell
added a commit
that referenced
this pull request
Oct 17, 2024
* initial freshness, start with overview Signed-off-by: Hannah Hunter <[email protected]> * continue freshness pass Signed-off-by: Hannah Hunter <[email protected]> * continue freshness Signed-off-by: Hannah Hunter <[email protected]> * finish freshness pass Signed-off-by: Hannah Hunter <[email protected]> * typo Signed-off-by: Hannah Hunter <[email protected]> * add note about default app-max-concurrency Signed-off-by: Hannah Hunter <[email protected]> * add to args and annotations doc Signed-off-by: Hannah Hunter <[email protected]> * Update config.toml Signed-off-by: Hannah Hunter <[email protected]> * fix 1.15 link Signed-off-by: Hannah Hunter <[email protected]> * fix release Signed-off-by: Hannah Hunter <[email protected]> * other versions Signed-off-by: Hannah Hunter <[email protected]> * Add AWS IAM authentication fields in PostgreSQL components (#4311) * Add AWS IAM authentication fields in PostgreSQL components Signed-off-by: Anton Troshin <[email protected]> * change wording Signed-off-by: Anton Troshin <[email protected]> --------- Signed-off-by: Anton Troshin <[email protected]> Co-authored-by: Hannah Hunter <[email protected]> * Adds clientCert and clientKey fields to spec Redis metadata fields (#4312) * Adds clientCert and clientKey fields to spec Redis metadata fields Signed-off-by: Elena Kolevska <[email protected]> * remove Signed-off-by: Elena Kolevska <[email protected]> * removes empty line Signed-off-by: Elena Kolevska <[email protected]> --------- Signed-off-by: Elena Kolevska <[email protected]> Co-authored-by: Mark Fussell <[email protected]> * Fix: Scheduler Actor Reminders Wording (#4320) * update phrasing to be scheduler actor reminders bc the jobs api has nothing to do with it really Signed-off-by: Cassandra Coyle <[email protected]> * Update daprdocs/content/en/operations/support/support-preview-features.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> Co-authored-by: Mark Fussell <[email protected]> * add storageClass example for s3 metadata (#4308) * add storageClass example to docs Signed-off-by: Cassandra Coyle <[email protected]> * add field to table Signed-off-by: Cassandra Coyle <[email protected]> * update data indentation for example curl Signed-off-by: Cassandra Coyle <[email protected]> * Update daprdocs/content/en/reference/components-reference/supported-bindings/s3.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> * tweaks Signed-off-by: Cassandra Coyle <[email protected]> * add to template example Signed-off-by: Cassandra Coyle <[email protected]> * add doc link for storage class Signed-off-by: Cassandra Coyle <[email protected]> * Update daprdocs/content/en/reference/components-reference/supported-bindings/s3.md Signed-off-by: Mark Fussell <[email protected]> * Update daprdocs/content/en/reference/components-reference/supported-bindings/s3.md Signed-off-by: Mark Fussell <[email protected]> * Update daprdocs/content/en/reference/components-reference/supported-bindings/s3.md Signed-off-by: Mark Fussell <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> Signed-off-by: Mark Fussell <[email protected]> Co-authored-by: Mark Fussell <[email protected]> * Add Prometheus auto service discovery instructions to prometheus.md - Updated prometheus.md with instructions for setting up Prometheus auto service discovery for Dapr and sidecar targets. * Add Prometheus auto service discovery instructions to prometheus.md - Updated prometheus.md with instructions for setting up Prometheus auto service discovery for Dapr and sidecar targets. Signed-off-by: Maulin Desai <[email protected]> * clarify/correct quickstarts Signed-off-by: Hannah Hunter <[email protected]> * clarify docs (#4324) Signed-off-by: Hannah Hunter <[email protected]> * Format service discovery instructions Updated the navigation instructions to use bold text for "Status" and "Service Discovery" for better visual clarity. Signed-off-by: Maulin Desai <[email protected]> * add note about implicit retries (#4325) Signed-off-by: Hannah Hunter <[email protected]> * Add Jobs API to Dapr slidedeck Signed-off-by: Marc Duiker <[email protected]> * Update daprdocs/content/en/operations/configuration/configuration-overview.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> * Update daprdocs/content/en/operations/configuration/configuration-overview.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> * Update daprdocs/content/en/operations/configuration/configuration-overview.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> * Update daprdocs/content/en/operations/configuration/configuration-overview.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> * Update daprdocs/content/en/operations/configuration/configuration-overview.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> * last update per mark review Signed-off-by: Hannah Hunter <[email protected]> * docs: init scheduler in the docker compose example Signed-off-by: Mike Nguyen <[email protected]> * update per mark, pt 2 Signed-off-by: Hannah Hunter <[email protected]> * fixed yaml syntax for v2alpha1 example (#4335) Signed-off-by: Adrian Hristov <[email protected]> * Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * add notes about namespacing Signed-off-by: Hannah Hunter <[email protected]> * update latest version (#4341) Signed-off-by: Hannah Hunter <[email protected]> * Add Kafka escapeHeaders documentation (#4332) * Add Kafka escapeHeaders documentation Signed-off-by: Anton Troshin <[email protected]> * update the escapeHeaders setting docs Signed-off-by: Anton Troshin <[email protected]> * review fixes Signed-off-by: Anton Troshin <[email protected]> --------- Signed-off-by: Anton Troshin <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> * Update roadmap.md (#4340) * Update roadmap.md Signed-off-by: Yaron Schneider <[email protected]> * Update roadmap.md Signed-off-by: Yaron Schneider <[email protected]> --------- Signed-off-by: Yaron Schneider <[email protected]> * conductor update (#4344) * fix job api http reference (#4343) Signed-off-by: yaron2 <[email protected]> Co-authored-by: Mark Fussell <[email protected]> * update alias (#4347) * Updated workflow to reflect deprecation of Workflow methods on client (#4336) Signed-off-by: Whit Waldo <[email protected]> Co-authored-by: Hannah Hunter <[email protected]> * rm escape (#4348) Signed-off-by: Cassandra Coyle <[email protected]> * clarify per josh comment Signed-off-by: Hannah Hunter <[email protected]> * Fixed cron schedule table Signed-off-by: Whit Waldo <[email protected]> * Tweaked the endpoint description and example to reflect that the protocol may or may not be necessary based on the provider used. Signed-off-by: Whit Waldo <[email protected]> * Updated to reflect the need for the protocol on the zipkin endpoint though it's not necessary on the otel endpoint. Signed-off-by: Whit Waldo <[email protected]> * update latest version to 1.14.2 (#4352) Signed-off-by: Hannah Hunter <[email protected]> Co-authored-by: Mark Fussell <[email protected]> * Update Job HTTP request API (#4349) According to dapr/dapr#8083 Signed-off-by: joshvanl <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> * Helm: Revert Scheduler storage quota size to `1Gi` (#4354) In v1.14.3, the storage quota size for the Scheduler volume was increased from `1Gi` to `16Gi`. This is because users where encountering disk exhaustion fatal errors on the Scheduler under normal usage. Because the volume size request field is protected from updates, Dapr version upgrades to v1.14.3 failed without manual intervention. Reverts the Scheduler storage quota size back to `1Gi`, and adds warnings that the volume size may need to be increased for production deployments. See: dapr/dapr#8107 Signed-off-by: joshvanl <[email protected]> * Reflecting valid value of 0-6, not 0-7 in jobs schedule Signed-off-by: Whit Waldo <[email protected]> * Clarifiied need for the actorStateStore property in docs, regardless of whether the actor actually stores any state. Signed-off-by: Whit Waldo <[email protected]> * Reworded slightly Signed-off-by: Whit Waldo <[email protected]> * Update workflow-patterns.md Make monitor code samples consistent between python/go and all other examples. * Python and Go are using seconds * Everything else is in minutes. Signed-off-by: Vasily Chekalkin <[email protected]> * update latest and recalled versions (#4360) Signed-off-by: Hannah Hunter <[email protected]> * Update setup-azure-servicebus-topics.md Signed-off-by: Andrew Riddlestone <[email protected]> * Update howto-invoke-non-dapr-endpoints.md (#4369) Update service invocation steps according to diagram Signed-off-by: Michael Klich <[email protected]> * Update daprdocs/content/en/reference/components-reference/supported-pubsub/setup-azure-servicebus-topics.md Signed-off-by: Mark Fussell <[email protected]> * Workflow limitations change (#4367) * workflow limitations change Signed-off-by: yaron2 <[email protected]> * Update daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-overview.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Mark Fussell <[email protected]> * Update daprdocs/content/en/developing-applications/building-blocks/workflow/workflow-overview.md Co-authored-by: Hannah Hunter <[email protected]> Signed-off-by: Mark Fussell <[email protected]> --------- Signed-off-by: yaron2 <[email protected]> Signed-off-by: Mark Fussell <[email protected]> Co-authored-by: Mark Fussell <[email protected]> Co-authored-by: Hannah Hunter <[email protected]> * rm decoding (#4373) Signed-off-by: Cassandra Coyle <[email protected]> * fix misleading wording (#4379) Signed-off-by: yaron2 <[email protected]> * [Jobs API] Describe Triggered Job Handling Assumptions (#4376) * add specific logic for what assumptions are made for triggered jobs for http, grpc, sdks Signed-off-by: Cassandra Coyle <[email protected]> * rm space Signed-off-by: Cassandra Coyle <[email protected]> * add a note about this applying to all programming languages to avoid confusion Signed-off-by: Cassandra Coyle <[email protected]> * Update howto-schedule-and-handle-triggered-jobs.md Signed-off-by: Yaron Schneider <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Yaron Schneider <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> * add roadmap to main page (#4386) Signed-off-by: yaron2 <[email protected]> * Update support (#4387) * Fixed typo (#4389) * Update daprdocs/config.toml Signed-off-by: Hannah Hunter <[email protected]> --------- Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Hannah Hunter <[email protected]> Signed-off-by: Anton Troshin <[email protected]> Signed-off-by: Elena Kolevska <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Cassie Coyle <[email protected]> Signed-off-by: Mark Fussell <[email protected]> Signed-off-by: Maulin Desai <[email protected]> Signed-off-by: Marc Duiker <[email protected]> Signed-off-by: Mike Nguyen <[email protected]> Signed-off-by: Adrian Hristov <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Yaron Schneider <[email protected]> Signed-off-by: yaron2 <[email protected]> Signed-off-by: Whit Waldo <[email protected]> Signed-off-by: joshvanl <[email protected]> Signed-off-by: Vasily Chekalkin <[email protected]> Signed-off-by: Andrew Riddlestone <[email protected]> Signed-off-by: Michael Klich <[email protected]> Co-authored-by: Anton Troshin <[email protected]> Co-authored-by: Elena Kolevska <[email protected]> Co-authored-by: Mark Fussell <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Maulin Desai <[email protected]> Co-authored-by: Marc Duiker <[email protected]> Co-authored-by: Mike Nguyen <[email protected]> Co-authored-by: Adrian Hristov <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Whit Waldo <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: Josh van Leeuwen <[email protected]> Co-authored-by: Vasily Chekalkin <[email protected]> Co-authored-by: Andrew Riddlestone <[email protected]> Co-authored-by: Michael Klich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to tweak the phrasing bc the
SchedulerRemindersfeature flag doesn't use the jobs api at all. It is simply storing the actor reminders in the Scheduler control plane service instead of the old actor reminder subsystem. I think it is confusing to putjob actor remindershere bc it doesn't use/touch the jobs api at all. The jobs api is user facing, this preview feature does not utilize that user facing jobs api at all it does utilize the Scheduler so there should be a distinction there and we should not overlap the concepts.